fix: is_allowed_nocache resolves roles once per org, not per rule
release / release (push) Canceled after 0s

Steps 1, 2, 4 and 5 called get_comprehensive_roles() for every row of
morbac.rules (and org_in_scope() per row), so a decision cost grew with
every tenant's rules: ~240 ms with 2376 rules across 27 orgs. Roles are now
resolved once per org where the user can hold one and that has a rule for
the request, rules are read through those (org, role) pairs, and
org_in_scope() runs once per (org, scope) pair. Decisions are unchanged.

Release 1.0.1 with the 1.0.0 -> 1.0.1 upgrade script. Test 17 compares
every decision with the 1.0.0 body on a seeded random fixture and checks
the cost no longer follows unrelated tenants' rules. bump_version.sh no
longer rewrites the PGXN meta-spec version.
This commit is contained in:
2026-10-14 23:41:00 +02:00
parent 3e8380d4f7
commit 1cf23c37ce
9 changed files with 931 additions and 51 deletions
+17
View File
@@ -5,6 +5,22 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [1.0.1] - 2026-10-14
### Fixed
- `is_allowed_nocache()` (and so every uncached `is_allowed()`) resolved the
user's roles once per row of the whole `rules` table, calling
`get_comprehensive_roles()` and `org_in_scope()` for every rule of every
tenant: about 240 ms per decision with 2376 rules across 27 orgs. Roles are
now resolved once per org where the user can hold one and that has a rule for
the requested activity and view, and matching rules are read through those
(org, role) pairs; `org_in_scope()` runs once per (org, scope) pair. Cost no
longer grows with other tenants' rules. Decisions are unchanged, checked
against the 1.0.0 implementation on a randomized fixture
(`tests/17_is_allowed_equivalence.sql`).
- `tools/bump_version.sh` no longer rewrites the PGXN `meta-spec` version in
`META.json`.
## [1.0.0] - 2026-07-25
### Added
@@ -55,4 +71,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
`rls_check(activity, view, row_org_id[, row_user_id])` for row-scoped tables
where a NULL `row_org_id` means the record is unattributed
[1.0.1]: https://github.com/crudylabs/pgmorbac/releases/tag/v1.0.1
[1.0.0]: https://github.com/crudylabs/pgmorbac/releases/tag/v1.0.0